Skip to content

feat: error pages #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
faria-s merged 8 commits into from
Sep 23, 2024
Merged

feat: error pages #74

faria-s merged 8 commits into from
Sep 23, 2024

Conversation

@faria-s
Copy link
Contributor

@faria-s faria-s commented Sep 16, 2024

No description provided.

@faria-s faria-s self-assigned this Sep 16, 2024
@faria-s faria-s marked this pull request as ready for review September 16, 2024 22:23
AfonsoMartins26
AfonsoMartins26 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@AfonsoMartins26 AfonsoMartins26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!👍

ruilopesm
ruilopesm reviewed Sep 17, 2024
View reviewed changes
ruilopesm
ruilopesm reviewed Sep 23, 2024
View reviewed changes
ruilopesm
ruilopesm reviewed Sep 23, 2024
View reviewed changes
ruilopesm
ruilopesm reviewed Sep 23, 2024
View reviewed changes
ruilopesm
ruilopesm reviewed Sep 23, 2024
View reviewed changes
@faria-s
Copy link
Contributor Author

faria-s commented Sep 23, 2024

Waiting for the tests to run, missing a commit. On it

@faria-s
Copy link
Contributor Author

faria-s commented Sep 23, 2024

Ok, Done

ruilopesm
ruilopesm approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 🙌🏼

AfonsoMartins26
AfonsoMartins26 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@AfonsoMartins26 AfonsoMartins26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀

@faria-s faria-s merged commit 39a59b1 into main Sep 23, 2024
@faria-s faria-s deleted the sf/error-pages branch September 23, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaodiaslobo joaodiaslobo joaodiaslobo approved these changes

@AfonsoMartins26 AfonsoMartins26 AfonsoMartins26 approved these changes

+1 more reviewer

@ruilopesm ruilopesm ruilopesm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@faria-s faria-s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@faria-s @joaodiaslobo @ruilopesm @AfonsoMartins26 @MarioRodrigues10